Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finished all tasks #106

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RalphOrland
Copy link

now I wait

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more descriptive key name like 'company_name' instead of 'name' for the 'companies' array items.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some feedback on the code:

  1. It looks like there are some unnecessary blank lines in the code. Please remove them.
  2. The function formatTimeFromCreatedAt and formatNumberWithSpaces are defined inside the makeTable function. It's generally better to define them outside so they can be reused.
  3. The commented out code for local time is unnecessary and can be removed.

Other than that, the code looks good!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the changes! I have a couple of suggestions:

  1. In line 7, instead of using lightblue, it might be better to use a more descriptive color name.
  2. In line 12, there seems to be an extra whitespace after the colon.

Other than that, the code looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants