Fixes javascript-crm Issues #1 to #4 #112
Conversation
There was a problem hiding this comment.
Consider providing a brief explanation for the change in the comment.
There was a problem hiding this comment.
Great job on the changes! I have a few suggestions:
-
Instead of using console.log to log the 'companies' array, consider using a logger library like 'winston' or 'debug'. This will provide more flexibility and control over logging.
-
It would be helpful to add comments explaining the purpose of the code block where you rearrange the company fields. This will make the code more readable and maintainable.
-
When reformatting the 'created_time' variable, consider using a more descriptive variable name instead of 'reformatted_time'. This will make the code easier to understand.
-
In the 'makeTable' function, consider adding error handling for cases where the API call fails. This will improve the robustness of the code.
| border-collapse: collapse; | ||
| border: 3px solid purple; | ||
| border: 3px solid lightblue; | ||
| } | ||
|
|
There was a problem hiding this comment.
The changes in this PR look great! I have a couple of suggestions:
- On line 19, it looks like the indentation is off. Please make sure it aligns with the previous line.
- On line 22, the color 'lightblue' might not provide enough contrast with the text. Consider using a darker color to improve readability.
Overall, great work!
No description provided.