Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix infinite loop in useEffect and add empty cart #53

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix infinite loop in useEffect and add empty cart #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a92dfd
fix infinite loop
mattpauls Feb 19, 2023
b5a8c4d
add cart is empty
mattpauls Feb 20, 2023
a048ef6
show cart empty when cart.length is 0
mattpauls Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Components/Cart.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Dialog, Transition } from "@headlessui/react";
import { XIcon } from "@heroicons/react/outline";
import { XIcon, ShoppingCartIcon } from "@heroicons/react/outline";
import React, { Fragment } from "react";

export default function Cart({ open, setOpen, cart, updateCart }) {
Expand Down Expand Up @@ -37,7 +37,7 @@ export default function Cart({ open, setOpen, cart, updateCart }) {
>
<div className="pointer-events-auto w-screen max-w-md">
<div className="flex h-full flex-col overflow-y-scroll bg-white shadow-xl">
<div className="flex-1 overflow-y-auto py-6 px-4 sm:px-6">
<div className="flex flex-col flex-1 overflow-y-auto py-6 px-4 sm:px-6">
<div className="flex items-start justify-between">
<Dialog.Title className="text-lg font-medium text-gray-900"> Shopping cart </Dialog.Title>
<div className="ml-3 flex h-7 items-center">
Expand All @@ -51,7 +51,11 @@ export default function Cart({ open, setOpen, cart, updateCart }) {
</button>
</div>
</div>

{cart.length == 0 &&
<div className="flex flex-col justify-center items-center flex-1">
<ShoppingCartIcon className="h-12 w-12" />
<span className="pt-2">Your Cart is Empty.</span>
</div>}
<div className="mt-8">
<div className="flow-root">
<ul role="list" className="-my-6 divide-y divide-gray-200">
Expand Down
2 changes: 1 addition & 1 deletion src/Components/ProductTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default function ProductTable({ cart, updateCart }) {
setProducts(body);
};
fetchProducts();
});
}, []);

return (
<div className="bg-white">
Expand Down