Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all three issues #5

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

brudevtek
Copy link

Fixed all three issues as per the challenge description. Would you review the changes and let me know what you think? Thanks!

@sbmsr
Copy link
Member

sbmsr commented May 2, 2023

@brudevtek It seems there is an issue with the logic in App.tsx, specifically this line.

I'll give you a hint: try running JSON.parse("") in a javascript console (like chrome devtools, or a local node repl) and see what happens.

@brudevtek
Copy link
Author

@sbmsr Thanks for the hint. I understand what was the issue there, Json.parse can't parse empty string. I replaced the empty string with false and then provided another option in that case. Also, made some changes to ensure that if api fetch returns bad or no data, the app won't crash, but will display empty column instead. Unfortunately the PR is still failing the checks. Any other hint as to what I am doing wrong?
Side note: In the errors, i am seeing a "Build Application" item which I assume is one of the tasks. But in the provided db, there is no "Build Application" . There is a "Develop features" instead. is that intentional?

@sbmsr
Copy link
Member

sbmsr commented May 2, 2023

@brudevtek it seems like there are some empty <li> elements that have been added to the kanban board. could you look into removing them? They're breaking the tests.

a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants