-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed all three issues #5
base: main
Are you sure you want to change the base?
Conversation
@brudevtek It seems there is an issue with the logic in I'll give you a hint: try running |
…data and local storage is empty
@sbmsr Thanks for the hint. I understand what was the issue there, Json.parse can't parse empty string. I replaced the empty string with false and then provided another option in that case. Also, made some changes to ensure that if api fetch returns bad or no data, the app won't crash, but will display empty column instead. Unfortunately the PR is still failing the checks. Any other hint as to what I am doing wrong? |
@brudevtek it seems like there are some empty |
Fixed all three issues as per the challenge description. Would you review the changes and let me know what you think? Thanks!