-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Test page's code blocks #74
Open
antoninmrkvica
wants to merge
5
commits into
developer-portal:master
Choose a base branch
from
antoninmrkvica:ruby_code_test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3de8edf
Test for code block on markdown files
antoninmrkvica d38693e
rename variable "site" to "content", move comment, edit codes inside …
antoninmrkvica f4cbfb5
WIP: code_block_spec.rb refactoring
pvalena 92643b1
Script change
antoninmrkvica ceadc09
rename variables, change extract method and extend error message
antoninmrkvica File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
require 'spec_helper' | ||
require 'kramdown' | ||
require 'ap' | ||
|
||
content = File.join(File.dirname(__FILE__), '..','content', '**', '*.md') | ||
PAGES = Dir.glob(content) | ||
|
||
def extract_code(parent) | ||
codespans = [] | ||
parent.children.each do |child| | ||
|
||
# Checks ... parent value hasn't got any sibling or begin with '\n' | ||
#<<< TODO: ^^^ Why? | ||
if child.type == :codespan \ | ||
&& !child.value.nil? \ #<<< remove?, investigate | ||
&& !codespans.include?(child.value) \ #<<< remove, keep context | ||
&& ((parent.children.size == 1) || (child.value[/^\n/])) #<<< use start_with? | ||
|
||
codespans.push child.value.gsub "\n",' ' #<<< .split and add to codespans | ||
#<<< add .trim - white space in the beginning and end | ||
end | ||
|
||
codespans += extract_code(child) | ||
end | ||
codespans | ||
end | ||
|
||
PAGES.each do |page| | ||
generated_page = Kramdown::Document.new(File.read(page)) #<<< MD | ||
codespans = extract_code(generated_page.root) #<<< lines of code, rename? | ||
results = [] #<<< to Hash: {codespan => result} | ||
|
||
describe 'Command in Markdown file' do | ||
|
||
it 'has a good syntax' do #<<< passes syntax check | ||
codespans.each do |code| | ||
if code[/^\$/] #code starts with '$' | ||
results.push([code,system('bash', '-n', '-c', code, "&>/dev/null")]) #<<< do not execute here | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now it occured to me we could also do a |
||
expect(results[-1][1]).to be_truthy,"Something wrong with: '#{code}'" | ||
elsif code[/^\#/] #<<< code.starts_with? ?# | ||
#ap code | ||
else #code starts with something else | ||
#ap code | ||
end | ||
end | ||
end | ||
|
||
it 'does not begin with #' do | ||
skip | ||
end | ||
|
||
it 'starts with $' do | ||
skip | ||
end | ||
|
||
it 'runs dnf with sudo' do | ||
skip | ||
end | ||
|
||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me like we want to have different tests for various
code-lines
(commands).Meaning this logic could be deciding for the test enablement, but from the level above.