feat: add cell vertical alignment in tables#119
Merged
Conversation
developer0hye
force-pushed
the
feat/cell-valign
branch
from
March 4, 2026 22:59
4c784b3 to
4cf13a0
Compare
Add CellVerticalAlign enum (Top/Center/Bottom) and vertical_align field to TableCell IR. Parse vAlign from DOCX cell properties via serde_json. Render as table.cell(align: top/horizon/bottom) in Typst output. Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
developer0hye
force-pushed
the
feat/cell-valign
branch
from
March 6, 2026 15:01
d62ddce to
5a9d26f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CellVerticalAlign(Top/Center/Bottom) andvertical_alignto the publicTableCellIRvAlignand render Typsttable.cell(align: ...)overridesrows: (...)sizing so vertical alignment takes effect in fixed-height rowsWhy
Key changes
verticalAlignfrom DOCX cell propertiestrHeightwithhRule=exact) intoTableRow.heightCompatibility
TableCellis public throughoffice2pdf::ir, so addingvertical_alignis a public API change for downstream struct literals/destructuringTest plan
cargo test -p office2pdf table --lib --offlinecargo test -p office2pdf row_height --lib --offlineRelated: #111