fix(docx): resolve theme font references in styles and document defaults#316
Merged
Conversation
rFonts theme slots (asciiTheme="minorHAnsi" etc.) were ignored, so documents whose defaults or paragraph styles reference the theme font scheme fell back to Typst's Libertinus Serif instead of the theme's latin typeface (normally Calibri). Parse the theme fontScheme's minor/major latin typefaces from word/theme/theme1.xml and resolve theme slots wherever no literal font family is given — document defaults and paragraph styles alike. Related: #287 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rFontstheme slots (asciiTheme="minorHAnsi"etc.) were ignored: documents whose defaults or paragraph styles reference the theme font scheme fell back to Typst's Libertinus Serifword/theme/theme1.xmland resolve theme slots wherever no literal family is given — in document defaults and per paragraph styleTest plan
--checkclean; clippy-D warningscleanVisual verification (public mce-wpg fixture, 150 DPI)
pdffonts: before embeds LibertinusSerif-Regular; after embeds Calibri (the theme minor font), matching Word.Related: #287
🤖 Generated with Claude Code