fix(pptx): place vertical text correctly inside rotated frames and shapes#320
Merged
Conversation
…apes Vertical (bodyPr vert) text kept its insets on the unrotated axes and anchored its column at the frame edge, so inside preset shapes the column landed on the sloped boundary and clipped. Remap the insets into the rotated coordinate system, and center the column for text inside non-rectangular preset shapes — approximating the preset text rectangle we don't model; plain rectangular boxes keep their anchor. Related: #286 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bodyPr vert) text kept its insets on the unrotated axes and anchored its column at the frame edge — inside preset shapes the column landed on the sloped boundary and clipped (follow-up to PPTX: render vertical text from bodyPr vert #269/PPTX: preserve text rotation inside shapes #222)bodyPranchorTest plan
--checkclean; clippy-D warningscleanVisual verification (public shape-text-rotate fixture vs PowerPoint GT, 100 DPI)
The word sits fully inside the pentagon like PowerPoint instead of clipping at its left slope.
After-image re-audit
Remaining deviations on this fixture, each filed per root cause: the style-matrix outline (
lnRef) is not applied → #318; the pentagon preset geometry renders ~10% shorter than its box → #319. GT's column sits at ~35% from the left (preset text rect) vs our centered ~48% — accepted approximation, noted here.Related: #286
🤖 Generated with Claude Code