feat(xlsx): render embedded charts on chart-only sheets as line plots#324
Merged
Conversation
An embedded chart living on a sheet with no cells was dropped entirely (the sheet was skipped like #238's image-only sheets, which that fix did not extend to charts) — the audited workbook showed only source cells. Emit the sheet's charts on a page from both the streaming and non-streaming paths. Charts that omit <c:cat> now get implicit 1..N category labels like Excel, and line/area charts render as an axis-scaled polyline plot (gridlines, value/category axes, per-series lines with markers, legend) instead of a trend-indicator table. Related: #239 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<c:cat>now get implicit1..Ncategory labels like ExcelTest plan
--checkclean; clippy-D warningscleanVisual verification (public WithChart fixture vs Excel GT, chart page)
The two-series line chart (rising blue, dipping orange) renders with gridlines, a 1–6 category axis, and a legend, matching GT. Before, the chart was omitted entirely.
After-image re-audit
Minor accepted differences: value axis rounds to 0–20 (GT uses Excel's 0–18), and series 2 uses the Office accent2 orange (GT's chart XML applies a red). No new issues.
Related: #239
🤖 Generated with Claude Code