feat(pptx): render the SmartArt drawing cache#325
Merged
Conversation
SmartArt produced a blank slide when the diagram's data model carried no text nodes. PowerPoint ships a pre-rendered drawing cache (diagrams/drawingN.xml) with the actual shapes; render it when present. Resolve it through the slide rels → data model → dataModelExt relId → drawing part, parse each <dsp:sp> (geometry, theme-resolved fill and outline, text) and emit shape + text-box elements positioned relative to the diagram frame. Fall back to the structured node list when no drawing cache exists. Related: #223 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diagrams/drawingN.xml) with the actual shapes; render it when presentdataModelExtrelId → drawing part; parse each<dsp:sp>(geometry, theme-resolved fill and outline, text) and emit shape + text-box elements positioned relative to the diagram frameTest plan
--checkclean; clippy-D warningscleanVisual verification (public SmartArt fixture vs PowerPoint GT, 110 DPI)
The five blue blocks render in PowerPoint's 2/2/1 layout with the accent fill, matching GT; before was a blank slide.
Related: #223
🤖 Generated with Claude Code