feat: [US-043] PPTX parser - SmartArt diagrams (basic)#9
Merged
Conversation
Add SmartArt diagram support for PPTX presentations: - IR: SmartArt struct with text items, FixedElementKind::SmartArt variant - Parser: smartart.rs module with parse_smartart_data_xml() for extracting text from diagram data model XML (dgm:pt type="node" elements) and scan_smartart_refs() for detecting SmartArt graphicFrames in slide XML - Integration: parse_single_slide() scans for SmartArt references, resolves data files via slide .rels, and adds SmartArt elements - Codegen: renders SmartArt as bordered box with "SmartArt Diagram" header and bulleted list of text items - Tests: 8 unit tests (data parsing, ref scanning), 3 integration tests (PPTX with SmartArt), 3 codegen tests (rendering, empty, special chars) Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
nikith-18161
added a commit
to nikith-18161/office2pdf
that referenced
this pull request
Jun 8, 2026
- Fix failing test: update Double border style expectation to 'solid' - Fix cargo fmt violations across xlsx.rs, xlsx_cells.rs, xlsx_style.rs, typst_gen.rs - Fix incorrect paper size table: Statement (code 6) = 5.5x8.5in, Executive (code 7) = 7.25x10.5in, remove developer0hye#9 Envelope (code 19) from Letter grouping - Add zero-margins fallback: when pageMargins element is absent umya returns 0.0 for all sides; fall back to Excel defaults (0.75in top/bottom, 0.7in left/right) - Fix numeric right-align heuristic: use cell.get_value_number() instead of parsing the formatted string, avoiding false positives on text like '0050' and missing currency/percentage values - Revert get_formatted_value fallback to get_value: the fallback cannot fix the inlineStr case without an upstream fix and risks un-hiding intentionally hidden cells - Add TODO for vertical-align default inconsistency Signed-off-by: nikith-18161 <nikith.molaka@progentys.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dgm:relIdsingraphicFrameelementstype="node")smartart.rsparser module withparse_smartart_data_xml()andscan_smartart_refs()Test plan
cargo fmt --all -- --checkpassescargo clippy --workspace -- -D warningspassescargo test --workspacepasses (459 tests)cargo check --workspacepasses🤖 Generated with Claude Code