Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove redundant KUBECONFIG env var #133

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 13, 2023

What does this PR do

Remove redundant KUBECONFIG env var since kubeconfig is mounted as a Secret and env var is set by dashboard [1]

Reference issue

https://issues.redhat.com/browse/CRW-4332

[1] eclipse-che/che-dashboard#950

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 cc @AObuchow

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

@AObuchow: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AObuchow, l0rd, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants