Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: petvet page - cadastro de pet etapa 8 #114

Merged
merged 26 commits into from
Jun 6, 2024
Merged

Conversation

juliaam
Copy link
Contributor

@juliaam juliaam commented Mar 19, 2024

Closes #110

Feature

Página de cadastro do petvet

Feature
  • Description
    Página de petvet, equivalente a etapa 8 do cadastro
Visual evidences: Tela desktop:

image

Tela mobile:

image

Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Observações: É preciso que seja colocado a variação do radiobutton sem a borda,

@juliaam juliaam marked this pull request as draft March 19, 2024 21:40
@juliaam
Copy link
Contributor Author

juliaam commented Mar 21, 2024

aguardando componente de input checkbox mergeado e componente de vacina

@juliaam juliaam force-pushed the issue-110 branch 2 times, most recently from 3b87159 to fe7a6d3 Compare May 8, 2024 15:24
@juliaam juliaam force-pushed the issue-110 branch 2 times, most recently from 3a50e04 to 109ee7d Compare May 20, 2024 15:45
@juliaam juliaam marked this pull request as ready for review May 21, 2024 21:29
@juliaam juliaam requested review from hxsggsz and Alecell May 22, 2024 04:53
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preciso que ajuste o story pra que eu possa avaliar o scss

src/components/Vaccine/index.js Show resolved Hide resolved
src/components/Vaccine/index.js Show resolved Hide resolved
src/components/Vaccine/index.js Show resolved Hide resolved
src/stories/PetVetPage.stories.js Show resolved Hide resolved
src/home/components/PetVetPage/index.js Outdated Show resolved Hide resolved
src/home/components/PetVetPage/index.js Outdated Show resolved Hide resolved
src/home/components/PetVetPage/index.js Outdated Show resolved Hide resolved
src/home/components/PetVetPage/index.js Outdated Show resolved Hide resolved
src/home/components/PetVetPage/index.js Show resolved Hide resolved
@juliaam juliaam requested a review from Alecell May 22, 2024 13:47
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olha o video que mandei no discord, precisamos de um ajuste no comportamento!

src/components/Vaccine/index.scss Outdated Show resolved Hide resolved
src/stories/PetVetPage.stories.js Show resolved Hide resolved
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minha primeira reação ao seu componente foi: FODA, muito bom!

Precisamos de mais espaçamento entre o final do formulário de vacina e o botão, ta muito afogado!

Atenção aos detalhes, no mobile a parte do botão deve estar assim:
image

@Alecell Alecell merged commit e5b2421 into devhatt:main Jun 6, 2024
3 checks passed
JonasGz pushed a commit to JonasGz/pet-dex-frontend-p4n4 that referenced this pull request Jun 15, 2024
* feat: desktop css and html petdex componente page

* fix: html and css finished

* fix: button and content

* fix: emit

* fix: index js

* fix: remove import petvet

* fix: fonts

* fix: send events

* fix: add semicolon

* fix: base desktop

* feat: add radios

* fix: styles of petvet

* fix: petvetpage and vacine improvments

* fix: directory name

* feat: radio groups and new format

* feat: list vaccines

* feat: component storybook

* fix: font name

* fix: stories, nomenclature and indentation

* fix: box shadow vaccine

* fix: heieght to container in storybook

* fix: page and component scroll

* fix: petvetpage footer

* fix: margin in footer

* fix: stories home behavior

* fix: better reading stories
JonasGz pushed a commit to JonasGz/pet-dex-frontend-p4n4 that referenced this pull request Jun 15, 2024
* feat: desktop css and html petdex componente page

* fix: html and css finished

* fix: button and content

* fix: emit

* fix: index js

* fix: remove import petvet

* fix: fonts

* fix: send events

* fix: add semicolon

* fix: base desktop

* feat: add radios

* fix: styles of petvet

* fix: petvetpage and vacine improvments

* fix: directory name

* feat: radio groups and new format

* feat: list vaccines

* feat: component storybook

* fix: font name

* fix: stories, nomenclature and indentation

* fix: box shadow vaccine

* fix: heieght to container in storybook

* fix: page and component scroll

* fix: petvetpage footer

* fix: margin in footer

* fix: stories home behavior

* fix: better reading stories
JonasGz pushed a commit to JonasGz/pet-dex-frontend-p4n4 that referenced this pull request Jun 15, 2024
* feat: desktop css and html petdex componente page

* fix: html and css finished

* fix: button and content

* fix: emit

* fix: index js

* fix: remove import petvet

* fix: fonts

* fix: send events

* fix: add semicolon

* fix: base desktop

* feat: add radios

* fix: styles of petvet

* fix: petvetpage and vacine improvments

* fix: directory name

* feat: radio groups and new format

* feat: list vaccines

* feat: component storybook

* fix: font name

* fix: stories, nomenclature and indentation

* fix: box shadow vaccine

* fix: heieght to container in storybook

* fix: page and component scroll

* fix: petvetpage footer

* fix: margin in footer

* fix: stories home behavior

* fix: better reading stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Criação da tela de Petvet
4 participants