feat: add login form #259
Merged
feat: add login form #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alecell
suggested changes
Jun 5, 2024
There was a problem hiding this comment.
Man seu código é muito bem escrito e legivel! De verdade, muito bom, fiz vários pontos conceituais de CSS, erros bem comuns então fica tranquilo faz parte, mas em nivel de leitura seu código é praticamente impecavel, parabens de novo!
O icone de olho cortado é na verdade um botão que exibe ou esconde a senha, precisamos colocar essa funcionalidade!
Sobre o icone de patinha que fica logo em cima:
Ele tem um problema estrutural e de estyling escalavel, fiz um vídeozinho explicando
…ependencies in login component
Alecell
suggested changes
Jun 12, 2024
DominMFD
reviewed
Jun 13, 2024
DominMFD
approved these changes
Jun 14, 2024
JonasGz
pushed a commit
to JonasGz/pet-dex-frontend-p4n4
that referenced
this pull request
Jun 15, 2024
* feat: add login form * refactor: renamed variables and functions to enhance readability and maintainability * refactor: change p tag to span for less robust text * refactor: resolve issue with position:absolute and background color dependencies in login component * refactor: keep style import as last import * refactor: isolate breakpoint * refactor: fix the use of spacing and relative positions * refactor: improve visibility of the text in the input when there is an error * refactor: add class to control error display * refactor: remove line-height with unity * refactor: improve error message display for form inputs * refactor: remove early return * refactor: fix breakpoint * refactor: decrease button spacing * refactor: improve code reading * refactor: add emit login event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239
Feature
Desenvolvimento do Componente de Formulário de Login de Usuário. O componente contém campos essenciais para email e senha com validações para garantir segurança dos dados.
Visual evidences 🖼️