Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Size Selector Component #265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

JonasGz
Copy link
Contributor

@JonasGz JonasGz commented Jun 13, 2024

Closes #23

Feature

Criação do componente de seleção de peso.

Visual evidences 🖼️

DESKTOP
desktop

MOBILE
mobile

plaay

Checklist
  • [ x ] Issue linked
  • [ x ] Build working correctly
  • Tests created
Additional info N/A

src/components/SizeSelector/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temos um problema de comportamento, precisamos que quando um size for selecionado ele seja animado para o centro e ai fique em destaque, da forma que está agora é um problema de usabilidade

Essa sessão aqui é um bom exemplo, porém precisamos que a troca de size tambem seja animada alem da troca de posição
https://www.medcel.com.br/serie
image

src/components/SizeSelector/index.js Show resolved Hide resolved
@JonasGz JonasGz force-pushed the issue-23 branch 2 times, most recently from b969706 to f013e61 Compare June 15, 2024 13:11
@Alecell Alecell mentioned this pull request Jun 19, 2024
3 tasks
@JonasGz JonasGz force-pushed the issue-23 branch 3 times, most recently from b852626 to b7f79b7 Compare July 2, 2024 21:15
feat: add responsive

chore: changed imgs to template sting

fix: translation bug mobile

fix: add aria-checked event

feat: create new sizeSelector

feat: create methods and add navigation with keyboard

feat: finish component

fix: remove css noPet

fix: remove justify-content: center
@JonasGz
Copy link
Contributor Author

JonasGz commented Jul 2, 2024

Temos um problema de comportamento, precisamos que quando um size for selecionado ele seja animado para o centro e ai fique em destaque, da forma que está agora é um problema de usabilidade

Essa sessão aqui é um bom exemplo, porém precisamos que a troca de size tambem seja animada alem da troca de posição https://www.medcel.com.br/serie image

refiz todo o componente e agora parece estar adequado para o que queremos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desenvolvimento de Componente Slider com Controle de Navegação
3 participants