Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 263 - Atualizar componente TextInput #266

Merged

Conversation

jessicasantosb
Copy link
Contributor

@jessicasantosb jessicasantosb commented Jun 14, 2024

Closes #263

Feature

Add functionality to toggle the visibility of the TextInput field and implement this feature in the LoginForm

Bugfix
  • Description
    N/A

  • Cause
    N/A

  • Solution
    N/A

Changelog N/A
Visual evidences 🖼️

Captura de tela 2024-06-14 125909
Captura de tela 2024-06-14 125824

Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Additional info N/A

Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O icone precisa ocupar um espaço "real" no input se não vai acontecer de o texto e o icone ficarem sobrepujados. Talvez a melhor solução pra isso é ter um container em volta do input cujo tem a bordinha e talz, ai dentro tem o input e o possivel icone
O problema
image

Possivel solução
image

Pode me pingar se tiver dúvida!

src/components/TextInput/index.js Outdated Show resolved Hide resolved
src/components/TextInput/index.js Outdated Show resolved Hide resolved
src/components/TextInput/index.js Outdated Show resolved Hide resolved
src/components/TextInput/index.js Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@DominMFD DominMFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Falta mudar o componente no Storybook também.

src/components/TextInput/index.js Outdated Show resolved Hide resolved
src/components/TextInput/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@DominMFD DominMFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pra mim ta bom, parabéns!!!

src/components/TextInput/index.js Outdated Show resolved Hide resolved
src/components/TextInput/index.scss Show resolved Hide resolved
@Alecell Alecell merged commit 18e6b81 into devhatt:main Jun 24, 2024
3 checks passed
JonasGz pushed a commit to JonasGz/pet-dex-frontend-p4n4 that referenced this pull request Jun 29, 2024
* feat: add functionality to show/hide TextInput field

* refactor: include type password to TextInput

* fix: rename getType to setType and correct method call parameter

* fix: prevent icon from being overlaid and correct use of BEM classes

* refactor: delete eslint comment

* refactor: update TextInput storybook

* refactor: configure stylelint for scss formatting

* refactor: emit event when type changes

* fix: resolve text overlay issue

* fix: update event name to imperative form

---------

Co-authored-by: jessicasantosb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atualizar componente TextInput
4 participants