Issue 263 - Atualizar componente TextInput #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alecell
suggested changes
Jun 17, 2024
There was a problem hiding this comment.
O icone precisa ocupar um espaço "real" no input se não vai acontecer de o texto e o icone ficarem sobrepujados. Talvez a melhor solução pra isso é ter um container em volta do input cujo tem a bordinha e talz, ai dentro tem o input e o possivel icone
O problema
Possivel solução
Pode me pingar se tiver dúvida!
DominMFD
requested changes
Jun 17, 2024
diogocaronte
requested changes
Jun 17, 2024
DominMFD
requested changes
Jun 18, 2024
DominMFD
approved these changes
Jun 19, 2024
diogocaronte
approved these changes
Jun 19, 2024
Alecell
suggested changes
Jun 19, 2024
Alecell
approved these changes
Jun 24, 2024
JonasGz
pushed a commit
to JonasGz/pet-dex-frontend-p4n4
that referenced
this pull request
Jun 29, 2024
* feat: add functionality to show/hide TextInput field * refactor: include type password to TextInput * fix: rename getType to setType and correct method call parameter * fix: prevent icon from being overlaid and correct use of BEM classes * refactor: delete eslint comment * refactor: update TextInput storybook * refactor: configure stylelint for scss formatting * refactor: emit event when type changes * fix: resolve text overlay issue * fix: update event name to imperative form --------- Co-authored-by: jessicasantosb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263
Feature
Add functionality to toggle the visibility of the TextInput field and implement this feature in the LoginForm
Bugfix
Description
N/A
Cause
N/A
Solution
N/A
Changelog
N/AVisual evidences 🖼️
Checklist
Additional info
N/A