-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swiper utility function for touch swipe events #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O path do arquivo não está bom
Talvez src/utils/swiper.js já fique melhor
Lembrando que não estamos lidando com componentes/classes então não tem necessidade da letra maiúscula
91117cd
to
958e67f
Compare
7335772
to
dd88f82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cara ta muito bom seu PR, de verdade, só alguns ajustes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Com o meu commit seu PR ta aprovado!
Me fala oque achou pra saber se posso ou não mergear!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fechou
* feat: Add Swiper utility function for touch swipe events * test: Add swipe tests * refactor: eslint configuration and refactor based on a review * fix: update the method to assign the mock to event target * feat: allow configure deadZone * feat: add destroy method --------- Co-authored-by: Alecell <[email protected]> Co-authored-by: Diogo Ferreira Reis <[email protected]>
Closes #29
Add Swiper utility function for touch swipe events
Checklist
Visual Evidence