Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swiper utility function for touch swipe events #85

Merged
merged 6 commits into from
Mar 10, 2024

Conversation

JonySamarelli
Copy link
Contributor

@JonySamarelli JonySamarelli commented Feb 25, 2024

Closes #29

Add Swiper utility function for touch swipe events
Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Visual Evidence

image

Copy link
Contributor

@diogocaronte diogocaronte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O path do arquivo não está bom
Talvez src/utils/swiper.js já fique melhor
Lembrando que não estamos lidando com componentes/classes então não tem necessidade da letra maiúscula

src/utils/Swiper/Swiper.js Outdated Show resolved Hide resolved
src/utils/Swiper/Swiper.js Outdated Show resolved Hide resolved
src/utils/Swiper/Swiper.js Outdated Show resolved Hide resolved
src/utils/Swiper/Swiper.js Outdated Show resolved Hide resolved
src/utils/Swiper/Swiper.js Outdated Show resolved Hide resolved
src/utils/Swiper/Swiper.js Outdated Show resolved Hide resolved
src/utils/Swiper/Swiper.js Outdated Show resolved Hide resolved
src/utils/Swiper/Swiper.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cara ta muito bom seu PR, de verdade, só alguns ajustes

src/utils/swiper.js Outdated Show resolved Hide resolved
src/utils/swiper.js Outdated Show resolved Hide resolved
src/utils/swiper.js Outdated Show resolved Hide resolved
src/utils/swiper.spec.js Outdated Show resolved Hide resolved
src/utils/swiper.spec.js Outdated Show resolved Hide resolved
src/utils/swiper.spec.js Outdated Show resolved Hide resolved
src/utils/swiper.spec.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Com o meu commit seu PR ta aprovado!

Me fala oque achou pra saber se posso ou não mergear!

src/utils/swiper.js Outdated Show resolved Hide resolved
Copy link
Contributor Author

@JonySamarelli JonySamarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fechou

src/utils/swiper.js Outdated Show resolved Hide resolved
src/utils/swiper.js Outdated Show resolved Hide resolved
src/utils/swiper.js Show resolved Hide resolved
@PiluVitu PiluVitu merged commit b4039ec into devhatt:main Mar 10, 2024
DominMFD pushed a commit to DominMFD/pet-dex-frontend that referenced this pull request Mar 27, 2024
* feat: Add Swiper utility function for touch swipe events

* test: Add swipe tests

* refactor: eslint configuration and refactor based on a review

* fix: update the method to assign the mock to event target

* feat: allow configure deadZone

* feat: add destroy method

---------

Co-authored-by: Alecell <[email protected]>
Co-authored-by: Diogo Ferreira Reis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementação de Recurso de Swiping
4 participants