feat: input dinamic range slider #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariable on component build fix devhatt#26
diogocaronte
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Estamos lidando com um componente de slider mas ele está muito engessado.
Não consigo mudar o mínimo.
Não consigo mudar o máximo.
Não consigo mudar a unidade.
O componente está sugerindo um slider genérico mas ele está sendo especifico para peso. Não tenho nem a opção de remover o titulo.
hxsggsz
approved these changes
Mar 1, 2024
…onent storybook to follow pattern fix devhatt#26
hxsggsz
approved these changes
Mar 2, 2024
aalmeida00
approved these changes
Mar 2, 2024
diogocaronte
approved these changes
Mar 2, 2024
JonasGz
pushed a commit
to JonasGz/pet-dex-frontend-p4n4
that referenced
this pull request
Mar 4, 2024
* feat: input dinamic range slider fix devhatt#26 * fix: reverting changes on nopetregisredpage, this page should not be modified fix devhatt#26 * refactor: add breakpoint and scss vars in style file fix devhatt#26 * refactor: change html to span for semantic reasons and added a unit variable on component build fix devhatt#26 * style: hide unit span on mobile devices fix devhatt#26 * refactor: add getters and setters for RangeSlider values. change component storybook to follow pattern fix devhatt#26 * refactor: change variable name for better reading and understanding fix devhatt#26 * refactor: add options to storybook and unmount to remove event listeners fix devhatt#26 * refactor: sepated handlemove into handlemouse and handletouch move fix devhatt#26 * feat: add listener do key 'esc', when pressed the value resets fix devhatt#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
Feature
Criação do componente de range dinâmico. Com animação de movimento ao arrastar o botão.
Changelog
Funcionalidade do componente: quando o usuário clica no botão e arrasta o componente calcula a direção do mouse ou touch para dispositivos móveis e move o background na direção respectiva para dar a impressão de movimento para o usuário.Visual evidences 🖼️
Additional info
TODO: remover sigla kg em small devices, usar um span no lugar do h1, separar kg em outro span e esconder no mobile, passar kg ou lb na construção do componente