Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: k6 (Original) #1844

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Conversation

akhilgkrishnan
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE
#1843

Link to prove your SVG is correct and up-to-date.

https://k6.io

@akhilgkrishnan akhilgkrishnan changed the title new icon K6: (Original) new icon: K6 (Original) Jul 29, 2023
@akhilgkrishnan akhilgkrishnan changed the title new icon: K6 (Original) new icon: k6 (Original) Jul 29, 2023
@akhilgkrishnan
Copy link
Contributor Author

@Panquesito7 Can you review this PR

@akhilgkrishnan
Copy link
Contributor Author

@Thomas-Boi Can I get a review on this?

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR!
Sorry for the very late review, all of the maintainers have sadly been busy with our private lives most of this year, which is why we are looking for more maintainers (feel free to apply here if you want: #1471)

I did some nitpicking on the icon itself. Once the suggestions are accepted this PR will be accepted :)

icons/k6/k6-original.svg Outdated Show resolved Hide resolved
@Snailedlt Snailedlt requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team October 21, 2023 15:22
case fix

case fix

Added new icon K6: (Original)

case fix

case fix

requested changes updated
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks good and so does the JSON.

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 22, 2023
@Snailedlt Snailedlt merged commit e737448 into devicons:develop Oct 22, 2023
5 checks passed
@akhilgkrishnan akhilgkrishnan deleted the add-k6-icon branch October 22, 2023 10:28
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
case fix

case fix

Added new icon K6: (Original)

case fix

case fix

requested changes updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants