-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(workflows): update deprecated actions #2310
ci(workflows): update deprecated actions #2310
Conversation
@ReenigneArcher Have you tested that these workflows still work after updating to newer versions? |
Someone more familiar with this project should probably do that (I wouldn't know what to check for). I did check for breaking behavior changes though, and I don't believe there are any. Most of these actions I have updated myself in https://github.com/LizardByte over the years, throughout our 50+ repos, and not seen any issues. |
Hmm, I don't have time to test all of them any time soon. If not I suggest we either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check the updated versions, but i think this should be OK.
Only white spaces and updated Versions.
May be necessary to check changes between the old an new versions?
But i don't know much about github actions (yet).
This should be merged so development on other enhancements can continue. |
I created #2351 and then found this. Actions are failing due to the Jan 31 deadline for upgrading |
From what it seems none of the actions break the build when tested locally with ACT, and all version are up to date. |
@ReenigneArcher Can you update the branch and then I merge? |
28d71e8
to
f002870
Compare
@canaleal Done! |
Double check these details before you open a PR
Features
Some actions are deprecated and will automatically fail the job if those versions are specified.
See: https://github.com/ReenigneArcher/devicon/actions/runs/12240230225/job/34142538368
This PR closes NONE
Notes
types:
was corrected in thepeek_icons.yml
workflow.