Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: firebird (original, plain) #2313

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

new icon: firebird (original, plain) #2313

wants to merge 8 commits into from

Conversation

Bulani
Copy link

@Bulani Bulani commented Dec 10, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://www.firebirdsql.org/en/logos/

@Snailedlt Snailedlt changed the title Add new icon: firebird (original, plain) new icon: firebird (original, plain) Dec 11, 2024
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team December 11, 2024 18:07
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Dec 11, 2024
canaleal
canaleal reviewed Dec 22, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou for your contribution! Ive added some comments on what needs to be changed. If you need any help feel free to ask.

devicon.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the JSON everything looks good.

icons/firebird/firebird-original.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG is not scaled to 128x128
It is also optimized and does not reach the edges of the viewbox.

Please refer to the wiki to read more about the SVG requirements.
https://github.com/devicons/devicon/wiki/SVG-Standards

icons/firebird/firebird-plain.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SVG also has to be scaled and optimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal left review comments

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@weh weh Awaiting requested review from weh weh was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bulani @canaleal @Snailedlt