Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | OECD Mums #826

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Feature | OECD Mums #826

wants to merge 8 commits into from

Conversation

dean-breed
Copy link
Collaborator

@dean-breed dean-breed commented Sep 29, 2022

Mums and SDG for DDW next deployment. Ticket #684

Copy link
Contributor

@wakibi wakibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dean-breed, can we keep all external files i.e CSVs, zips, txt files etc at this repo?
https://github.com/devinit/ddw-data-update-configs/

Also, please rename the file and remove spaces. Let's use underscores instead.

@dean-breed
Copy link
Collaborator Author

@wakibi I can do both of those things but do I need to make any resulting changes due to the data being located differently?

@dean-breed
Copy link
Collaborator Author

@wakibi As for the filename, I generally prefer leaving it the same as the source to make traceability more clear but if the code really needs it to not have spaces, we can do that also.

@stale
Copy link

stale bot commented Dec 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 16, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stale stale bot closed this Dec 31, 2022
@edwinmp
Copy link
Collaborator

edwinmp commented Jun 8, 2023

I'm reopening this as I'm sure it had value - should have been check once the stale bot tagged it for closing.

@edwinmp edwinmp reopened this Jun 8, 2023
@stale stale bot removed the wontfix This will not be worked on label Jun 8, 2023
@edwinmp
Copy link
Collaborator

edwinmp commented Jun 8, 2023

Guess you'll have to take this all the way @wakibi

@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #826 (a820fac) into develop (244513c) will increase coverage by 10.55%.
The diff coverage is n/a.

❗ Current head a820fac differs from pull request most recent head 40a82d8. Consider uploading reports for the commit 40a82d8 to get more accurate results

@@             Coverage Diff              @@
##           develop     #826       +/-   ##
============================================
+ Coverage    46.33%   56.89%   +10.55%     
============================================
  Files          195      129       -66     
  Lines         7059     1965     -5094     
  Branches       522      522               
============================================
- Hits          3271     1118     -2153     
+ Misses        3684      743     -2941     
  Partials       104      104               

see 66 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edwinmp edwinmp changed the title Feature/oecd mums Feature | OECD Mums Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants