MKCalendarView's first day based on user's locale + minor bugfix. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If locale uses Sunday, Sunday is used. Otherwise, uses monday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
If you think it would be helpful, this pull request changes the behaviour of
MKCalendarViewso that if a left-most day isn't specified in the initializer the current locale's calendar is queried for the correct value, rather than assuming Sunday. If a day that isn't Sunday or Monday is returned, it assumes Monday.0c87ada also fixes a minor bug where if a
TKCalendarMonthViewControlleris initialized usinginitWithTimeZone:, the timezone argument is ignored.If you decide you want the bugfix without the default behaviour changed, I'd be happy to refactor that into its own request.
Cheers