You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because this plugin has to support OpenID providers as many as possible.
This PR would only allow authelia in the future.
One row was updated only in this pull request.
This pull request didn't remove the support of Keycloak.
Before update:
177: if access_token? # keycloak way...
After update:
191: if (access_token? && access_token.exclude?('authelia')) # keycloak way...
Explanation:
if condition true (access_token? && access_token.exclude?('authelia'))
it means the OpenID provider is Keycloak
else have to use another provider like Authelia.
Could you review this pull request, please.
Could you explain why you don't want to apply this pull request, please?
triplem, is there any issues with it, or should I add something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.