지원자 리스트 페이지 - 렌더링 성능 개선(issue #150) #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeongjun6364
requested review from
HongbiKo,
YouD0313,
hwookim and
layout-SY
layout-SY
approved these changes
Jan 28, 2025
HongbiKo
approved these changes
Jan 28, 2025
hwookim
reviewed
Jan 29, 2025
Collaborator
hwookim
left a comment
hwookim
left a comment
There was a problem hiding this comment.
실제로 이전-이후의 성능 개선이 얼마나 되었는지 수치로 확인해볼 수 있으면 좋겠네요 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현내용
지원자를 클릭했을 때, 불 필요한 리 렌더링이 발생하여 개선하였습니다.
사이드바의 경우, commit phase만 막기 위해 memo를 사용했지만, 아이템 메뉴를 가져오는 함수의 참조값이 달라지면서 render phase가 변경되어 재 렌더링이 발생하는 문제가 있었어요.
이를 useMemo를 사용하여 참조값 유지를 통해 문제 해결하였습니다.
[기존]
[개선 후]
연관이슈
close #150