모달창 디자인 수정 및 적용/notFound 페이지 생성 #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HongbiKo
requested review from
YouD0313,
hwookim,
hyeongjun6364 and
layout-SY
Closed
3 tasks
Collaborator
hyeongjun6364
left a comment
hyeongjun6364
left a comment
There was a problem hiding this comment.
모달이 덕분에 훨씬 예뻐졌네요! 고생하셨어요~
src/routes/AppRoutes.tsx
Outdated
| { | ||
| path: ROUTES.notFound, | ||
| element: <NotFoundPage />, | ||
| }, |
Collaborator
There was a problem hiding this comment.
홍비님 404페이지는 사용자가 잘못된 경로로 접근했을 경우 발생하는거니깐, 라우팅을 따로 설정할 필요는 없어보여요 :)
ErrorElement에 추가만 해주셔도 될 것 같아요
Collaborator
Author
There was a problem hiding this comment.
넵! 컴포넌트 디렉토리 common/page/notfound에 두었습니다!
hyeongjun6364
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현내용
구현 UI
모달창
기존 모달창
스타일 수정한 모달창
notFound 페이지
연관이슈
close #155