지원자 합/불합 페이지 - 대기상태, 결과 전송 구현(issue #152) #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeongjun6364
requested review from
HongbiKo,
Kim-Hyunhee,
YouD0313 and
layout-SY
YouD0313
approved these changes
Jan 30, 2025
hyeongjun6364
requested review from
YouD0313 and
hwookim
and removed request for
Kim-Hyunhee
hwookim
reviewed
Feb 2, 2025
| disabled, | ||
| ...props | ||
| }: ButtonProps) { | ||
| }: PropsWithChildren<ButtonProps>) { |
Collaborator
There was a problem hiding this comment.
ButtonHTMLAttributes에는 children이 없으려나요? 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현내용
지원자 상태를 변경하는 훅(usePassNonPassMutation)의 props를 isPass -> status로 변경하고
대기 상태로 변하면 쿼리 무효화가 진행되어 리스트가 리패치 되도록 구현하였습니다.
children은 propsWithChileren을 사용해 타입 안정성을 강화했습니다.
결과 전송버튼을 클릭하면, 사용자에게 확인을 한번 더 할 수 있는 모달은 추후 업데이트할게요!
연관이슈
close #152