공용 모달 적용 #172
Merged
공용 모달 적용 #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layout-SY
requested review from
HongbiKo,
YouD0313,
hwookim and
hyeongjun6364
HongbiKo
approved these changes
Feb 1, 2025
|
|
||
| const Modal = ({ children, isOpen, onClose }: ModalProps) => { | ||
| const modalRef = useRef<HTMLDivElement | null>(null); | ||
| const modalRefs = useOutsideClick(() => handleClose()); |
Collaborator
There was a problem hiding this comment.
useOutsideClick을 활용해서 로직이 더 간결해 졌네요! 감사합니다~
hwookim
reviewed
Feb 2, 2025
Comment on lines
+164
to
+166
| <Modal isOpen={isOpen} onClose={handleModalClose}> | ||
| {message} | ||
| </Modal> |
Collaborator
There was a problem hiding this comment.
다양한 디자인의 Modal을 쓰는 게 아니라면, 전역 상태관리를 통해서 하나의 Modal에 message를 바꾸는 방식으로 간소화시켜보는 방법도 있겠네요 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현내용
연관이슈
close #148