웹 접근성 테스트 #190
Merged
웹 접근성 테스트 #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeongjun6364
requested review from
HongbiKo,
YouD0313,
hwookim and
layout-SY
YouD0313
approved these changes
Feb 2, 2025
| return ( | ||
| <S.DropDownContainer ref={dropdownRef}> | ||
| <button className="toggle" onClick={() => setOpen(!open)}> | ||
| <div className='toggle' onClick={() => setOpen(!open)}> |
Collaborator
There was a problem hiding this comment.
왜 div로 변경하시나요?? 클래스네임말고 styled-component로 통일하기로 했으니 변경할때 바꿨어도 좋았을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현내용
웹 접근성 테스트를 도입하고 관련 오류를 해결했습니다.
접근성에 대한 ci스크립트도 추가했습니다.
color: #393939->color: #333333button요소에서 ->div로 변경ul,li요소로 통일연관이슈
close #188