Skip to content

page Home min-width 설정, 카드리스트 스킬태그 이미지 고정으로 수정 (# issue 195) #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YouD0313 merged 1 commit into from
Feb 4, 2025
Merged

page Home min-width 설정, 카드리스트 스킬태그 이미지 고정으로 수정 (# issue 195) #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/components/home/projectCardLists/cardList/CardList.styled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,15 @@ export const TagWrapper = styled.div<{ $positionPadding?: boolean }>`
z-index: 10;
`;

export const SkillTagImgWrapper = styled.div`
border: 1px solid ${({ theme }) => theme.color.grey};
border-radius: 50%;
`;

export const SkillTagImg = styled.img`
width: 2rem;
`;

export const EllipsisIconButton = styled.button`
display: flex;
justify-content: center;
Expand Down
5 changes: 3 additions & 2 deletions src/components/home/projectCardLists/cardList/CardList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import PositionButton from '../../../common/positionButton/PositionButton';
import SkillTagImg from '../../../common/skillTagBox/skillTag/skillTagImg/SkillTagImg';
import * as S from './CardList.styled';
import beginner from '../../../../assets/beginner.svg';
import Avatar from '../../../common/avatar/Avatar';
Expand Down Expand Up @@ -35,7 +34,9 @@ export default function CardList({ list }: CardListProps) {
<S.TagsWrapper>
{Boolean(list.skillTags.length) &&
listSkillTag.map((tag) => (
<SkillTagImg image={tag.img} key={tag.id} skillTag={tag.name} />
<S.SkillTagImgWrapper key={tag.id}>
<S.SkillTagImg src={tag.img} alt={tag.name} />
</S.SkillTagImgWrapper>
))}
{list.skillTags.length > listSkillTag.length && (
<S.EllipsisIconButton>+{othersSkill}</S.EllipsisIconButton>
Expand Down
1 change: 1 addition & 0 deletions src/pages/home/Home.styled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import styled from 'styled-components';

export const Container = styled.main`
width: 100%;
min-width: 22.7rem;
`;

export const Wrapper = styled.div`
Expand Down