Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/myProjectList.api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type {
import { httpClient } from './http.api';

export const getMyProjectLists = async () => {
const response = await httpClient.get<ApiManagedProjects>(`/project/my`);
const response = await httpClient.get<ApiManagedProjects>(`/user/project`);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

API 엔드포인트 변경을 확인했습니다.

엔드포인트가 /project/my에서 /user/project로 변경되었습니다. 백엔드 API 구조 변경에 따른 것으로 보입니다.

다른 파일에서 기존 엔드포인트를 사용하는 곳이 있는지 확인해보겠습니다:


🏁 Script executed:

#!/bin/bash
# Description: 기존 /project/my 엔드포인트를 사용하는 다른 파일 확인
# Expected: 모든 곳에서 일관되게 업데이트되었는지 확인

rg "/project/my" --type ts --type tsx

Length of output: 65


기존 /project/my 엔드포인트 사용처를 다시 한 번 전체 파일(.ts, .tsx)에서 확인합니다:


🏁 Script executed:

#!/bin/bash
# Description: /project/my 엔드포인트가 사용된 모든 .ts 및 .tsx 파일 검색
rg "/project/my" --glob '*.ts' --glob '*.tsx'

Length of output: 128


/project/my 엔드포인트 교체 및 디버깅 로그 제거 필요

다음 두 군데를 수정해주세요:

  • src/api/myProjectList.api.ts
    • 디버깅용 console.log(response) 제거
  • src/mock/manageProjectList.ts
    • 기존 ${import.meta.env.VITE_API_BASE_URL}/project/my${import.meta.env.VITE_API_BASE_URL}/user/project로 엔드포인트 변경
🤖 Prompt for AI Agents
In src/api/myProjectList.api.ts at line 8, remove the debugging console.log
statement that outputs the response after calling the updated endpoint
`/user/project`. Also, ensure that in src/mock/manageProjectList.ts the API
endpoint string is updated from
`${import.meta.env.VITE_API_BASE_URL}/project/my` to
`${import.meta.env.VITE_API_BASE_URL}/user/project` to reflect the backend API
change.

return response.data;
};

Expand Down
4 changes: 3 additions & 1 deletion src/api/mypage.api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ export const patchMyProfileImg = async (file: File) => {

export const getMyJoinedProjectList = async () => {
try {
const response = await httpClient.get<ApiJoinedProject>('/user/project');
const response = await httpClient.get<ApiJoinedProject>(
'/user/joinProject'
);

return response.data;
} catch (error) {
Expand Down
3 changes: 3 additions & 0 deletions src/assets/line.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
39 changes: 39 additions & 0 deletions src/components/admin/mainCard/MainCard.styled.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { Link } from 'react-router-dom';
import styled from 'styled-components';

export const Container = styled.div`
display: flex;
flex-direction: column;
border: 1px solid #ccc;
border-radius: ${({ theme }) => theme.borderRadius.primary};
`;

export const CardHeader = styled.div`
min-height: 50px;
display: flex;
justify-content: space-between;
align-items: center;
`;

export const Title = styled.h3`
margin-left: 20px;
`;

export const ShowAllArea = styled(Link)`
display: flex;
margin-left: 10px;
margin-right: 10px;
`;

export const ShowAllButton = styled.span`
font-size: 13px;
margin-right: 6px;
`;

export const ArrowRight = styled.img``;

export const Line = styled.hr``;

export const Wrapper = styled.div``;

export const MainContent = styled.div``;
31 changes: 31 additions & 0 deletions src/components/admin/mainCard/MainCard.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import * as S from './MainCard.styled';
import arrowRight from '../../../assets/ArrowRight.svg';
import React from 'react';

interface MainCardProps {
title: string;
moreLink?: string;
children: React.ReactNode;
}

const MainCard = ({ title, moreLink, children }: MainCardProps) => {
return (
<S.Container>
<S.CardHeader>
<S.Title>{title}</S.Title>
{moreLink && (
<S.ShowAllArea to={moreLink}>
<S.ShowAllButton>전체 보기</S.ShowAllButton>
<S.ArrowRight src={arrowRight} />
</S.ShowAllArea>
)}
</S.CardHeader>
<S.Line />
<S.Wrapper>
<S.MainContent>{children}</S.MainContent>
</S.Wrapper>
</S.Container>
);
};

export default MainCard;
3 changes: 3 additions & 0 deletions src/components/admin/mainCard/graphCard/GraphCard.styled.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import styled from 'styled-components';

export const Container = styled.div``;
8 changes: 8 additions & 0 deletions src/components/admin/mainCard/graphCard/GraphCard.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import React from 'react';
import * as S from './GraphCard.styled';

const GraphCard = () => {
return <S.Container>GraphCard Component</S.Container>;
};

export default GraphCard;
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import styled from 'styled-components';

export const Container = styled.div``;
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import React from 'react';
import * as S from './AllUserPreview.styled';

const AllUserPreview = () => {
return <S.Container>AllUserPreview Component</S.Container>;
};

export default AllUserPreview;
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import styled from 'styled-components';

export const Container = styled.div``;
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import React from 'react';
import * as S from './InquiresPreview.styled';

const InquiresPreview = () => {
return <S.Container>InquiresPreview Component</S.Container>;
};

export default InquiresPreview;
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import styled from 'styled-components';

export const Container = styled.div`
display: flex;
flex-direction: column;
padding: 20px;
`;

export const Wrapper = styled.div`
display: flex;
`;

export const Dot = styled.img`
margin-right: 7px;
`;

export const NoticeTitle = styled.p`
font-size: 18px;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
`;
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import React from 'react';
import * as S from './NoticePreview.styled';
import { useGetNotice } from '../../../../hooks/user/useGetNotice';
import line from '../../../../assets/line.svg';

const NoticePreview = () => {
const { noticeData } = useGetNotice({ keyword: '', page: 1 });

return (
<S.Container>
{noticeData?.notices.map((notice) => (
<S.Wrapper key={notice.id}>
<S.Dot src={line} />
<S.NoticeTitle>{notice.title}</S.NoticeTitle>
</S.Wrapper>
))}
</S.Container>
);
};

export default NoticePreview;
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import styled from 'styled-components';

export const Container = styled.div``;
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import React from 'react';
import * as S from './ReportsPreview.styled';

const ReportsPreview = () => {
return <S.Container>ReportsPreview Component</S.Container>;
};

export default ReportsPreview;
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ export const Container = styled.div`
overflow: hidden;
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
padding: 3px;
`;

Expand Down Expand Up @@ -40,6 +38,12 @@ export const Arrow = styled.img`
margin-bottom: 3px;
`;

export const NoAlarmContainer = styled.div`
display: flex;
justify-content: center;
align-items: center;
`;

export const NonContentsMessage = styled.p`
display: flex;
justify-content: center;
Expand Down
4 changes: 2 additions & 2 deletions src/components/common/header/Notification/Notification.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ const Notification = () => {

if (!AlarmData) {
return (
<S.Container>
<S.NoAlarmContainer>
<S.NonContentsMessage>알림이 없습니다.</S.NonContentsMessage>
</S.Container>
</S.NoAlarmContainer>
);
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import styled, { css } from 'styled-components';

export const Container = styled.div`
padding: 8px 0;
padding: 10px;
font-size: 14px;
`;

export const TypeArea = styled.div`
display: flex;
margin-left: 6px;
`;

export const Type = styled.p``;
Expand All @@ -22,13 +21,11 @@ export const ItemContent = styled.p`
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
margin-left: 6px;
`;

export const Time = styled.span`
color: #999;
font-size: 12px;
margin-left: 6px;
margin-right: 5px;
`;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const NotificationItem = ({ item }: NotificationItemProps) => {
return (
<Link to={route} onClick={close}>
<S.Container>
<S.ItemContent>{item.content}</S.ItemContent>
<S.ItemContent>{item.content} | </S.ItemContent>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

구분자 추가 목적은 이해하지만 더 나은 방법을 고려해보세요.

알림 내용 뒤에 구분자를 추가한 목적은 이해하지만, 하드코딩된 문자열 대신 CSS나 스타일드 컴포넌트를 통해 시각적 구분을 구현하는 것을 권장합니다.

CSS pseudo-element를 활용한 대안:

-        <S.ItemContent>{item.content} | </S.ItemContent>
+        <S.ItemContent>{item.content}</S.ItemContent>

그리고 styled 컴포넌트에서:

export const ItemContent = styled.div`
  &::after {
    content: ' | ';
    color: ${({ theme }) => theme.colors.gray};
  }
`;

이 방법의 장점:

  • 스타일과 내용의 분리
  • 테마를 통한 일관된 디자인 관리
  • 향후 구분자 변경 시 중앙화된 관리 가능
🤖 Prompt for AI Agents
In
src/components/common/header/Notification/NotificationItem/NotificationItem.tsx
at line 19, replace the hardcoded delimiter string " | " inside the JSX with a
CSS-based solution using a styled component's ::after pseudo-element. Modify the
styled component for ItemContent to include an ::after rule that adds the
delimiter with appropriate styling and theme color. This separates content from
presentation and centralizes delimiter styling for easier maintenance and
theming.

<S.TypeArea>
<S.Time>{timeAgo(item.createdAt)}</S.Time>
<S.TypeFilter>
Expand Down
4 changes: 2 additions & 2 deletions src/components/user/evaluation/EvaluationContent.styled.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,10 @@ export const CompletedButton = styled.button<{ $active?: boolean }>`
color: ${({ $active }) => ($active ? '#fff' : '#999')};
border: none;
border-radius: 4px;
cursor: ${({ $active }) => ($active ? 'pointer' : 'default')};
cursor: pointer;
transition: background-color 0.2s;

&:hover {
background-color: ${({ $active }) => ($active ? '#2f4a6b' : '#e0e0e0')};
background-color: '#e0e0e0';
}
`;
44 changes: 33 additions & 11 deletions src/components/user/evaluation/EvaluationContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,23 @@ interface EvaluationContentProps {
projectId: number;
projectName: string;
memberList: MemberList[];
isAllEvaluated: boolean;
}

const EvaluationContent = ({
projectId,
projectName,
memberList,
isAllEvaluated,
}: EvaluationContentProps) => {
const {
step,
notDone,
completedMember,
handleClickLeftUser,
handleClickOption,
handleNextStep,
handleCompletedMember,
currentScores,
isNotFill,
} = useEvaluationStep({ projectId, memberList });
Expand All @@ -42,18 +46,26 @@ const EvaluationContent = ({

<S.MainContent>
<S.Header>
<S.Title>{notDone[step]?.nickname}님 평가하기</S.Title>
<S.SubmitButton
size='primary'
schema='primary'
radius='primary'
onClick={handleNextStep}
>
제출하기
</S.SubmitButton>
<S.Title>
{isAllEvaluated
? '평가가 완료 되었습니다. '
: completedMember
? `${completedMember.nickname}님 평가 결과`
: `${notDone[step]?.nickname}님 평가하기`}
</S.Title>
Comment on lines +49 to +55
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

조건부 제목 렌더링 로직 개선 필요

현재 조건부 렌더링 로직이 복잡하고 우선순위가 명확하지 않습니다.

             <S.Title>
-              {isAllEvaluated
-                ? '평가가 완료 되었습니다. '
-                : completedMember
-                ? `${completedMember.nickname}님 평가 결과`
-                : `${notDone[step]?.nickname}님 평가하기`}
+              {(() => {
+                if (completedMember) {
+                  return `${completedMember.nickname}님 평가 결과`;
+                }
+                if (isAllEvaluated) {
+                  return '평가가 완료되었습니다.';
+                }
+                return `${notDone[step]?.nickname}님 평가하기`;
+              })()}
             </S.Title>

이렇게 하면 우선순위가 명확해집니다: 완료된 멤버 선택 > 전체 평가 완료 > 일반 평가 진행

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<S.Title>
{isAllEvaluated
? '평가가 완료 되었습니다. '
: completedMember
? `${completedMember.nickname}님 평가 결과`
: `${notDone[step]?.nickname}님 평가하기`}
</S.Title>
<S.Title>
{(() => {
if (completedMember) {
return `${completedMember.nickname}님 평가 결과`;
}
if (isAllEvaluated) {
return '평가가 완료되었습니다.';
}
return `${notDone[step]?.nickname}님 평가하기`;
})()}
</S.Title>
🤖 Prompt for AI Agents
In src/components/user/evaluation/EvaluationContent.tsx around lines 49 to 55,
the conditional rendering logic for the title is currently complex and the
priority order is unclear. Refactor the logic to clearly prioritize
completedMember first, then isAllEvaluated, and finally the default evaluation
step. This will make the rendering conditions more readable and maintainable by
explicitly checking completedMember before the other conditions.

{!completedMember && (
<S.SubmitButton
size='primary'
schema='primary'
radius='primary'
onClick={handleNextStep}
>
제출하기
</S.SubmitButton>
)}
</S.Header>
<S.MessageContainer>
{isNotFill && (
{isNotFill && !completedMember && (
<S.ErrorMessage>모든 질문에 답변해주세요.</S.ErrorMessage>
)}
</S.MessageContainer>
Expand All @@ -78,6 +90,7 @@ const EvaluationContent = ({
handleClickOption(questionNumber, optionValue)
}
value={optionValue + 1}
disabled={!!completedMember}
/>
<S.RadioLabel>{optionValue + 1}</S.RadioLabel>
<S.OptionLabel>{label}</S.OptionLabel>
Expand All @@ -94,7 +107,16 @@ const EvaluationContent = ({
{memberList
.filter((memberData) => memberData.evaluated)
.map((memberData) => (
<S.CompletedButton key={memberData.userId}>
<S.CompletedButton
key={memberData.userId}
onClick={() =>
handleCompletedMember(
memberData.userId,
memberData.nickname,
memberData.scores
)
}
>
{memberData.nickname}
</S.CompletedButton>
))}
Expand Down
5 changes: 3 additions & 2 deletions src/components/user/manageProjects/Card.styled.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,12 @@ export const RecruitmentEnd = styled.span`
font-weight: 800;
`;

export const EvaluateButton = styled(Link)`
export const EvaluateButton = styled(Link)<{ $isCompleted: boolean }>`
display: inline-flex;
flex-shrink: 0;
padding: 0.2rem 0.65rem;
background-color: #3e5879;
background-color: ${({ $isCompleted }) =>
$isCompleted ? `#2ADE1D` : `#3e5879`};
font-size: 0.9rem;
color: ${({ theme }) => theme.color.white};
border-radius: 10px;
Expand Down
4 changes: 3 additions & 1 deletion src/components/user/manageProjects/Card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ function Card({ project }: CardProps) {
<S.EvaluateButton
key={project.id}
to={`${ROUTES.evaluation}/${project.id}`}
state={{ isAllCompleted: project.isAllEvaluated }}
$isCompleted={project.isAllEvaluated}
>
평가하기
{project.isAllEvaluated ? '평가완료' : '평가하기'}
</S.EvaluateButton>
)}
{project.isDone && <S.RecruitmentEnd>모집 종료</S.RecruitmentEnd>}
Expand Down
Loading