-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update identify-web-user.mdx #188
base: main
Are you sure you want to change the base?
Conversation
no-work-item
🌟 EkLine ReviewerHello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page. For questions or feedback, please email [email protected]. |
Published docs preview URL: https://devrev-preview-270970c9-64c9-4c14-9285-ddb9c44bb9f3.docs.buildwithfern.com |
@@ -102,7 +102,7 @@ If you prefer a two-level structure, where users are directly associated with an | |||
|`account_ref` |A unique reference for the account. |string | | |||
|`display_name` | The name of the account that's shown on the widget. |string | | |||
|`domains` |The domain names of the accounts that the users belongs to. |array | | |||
| `phone_numbers` |The phone number associated with the account. |array | | |||
|`phone_numbers` |The phone number associated with the account must be in E.164 format. |array | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|`phone_numbers` |The phone number associated with the account must be in E.164 format. |array | | |
|`phone_numbers` |The phone number associated with the account in E.164 format. |array | |
| Attributes | Description | Type | Required | Unique | | ||
|---------------|-----------------------------------------------------------------------------|--------|----------|--------| | ||
| user_ref | A unique user reference that the DevRev app uses for identifying your users. This parameter is required. | string | ✅ | Yes | | ||
| email | The email address of the customer. It's used for sending email notifications of any support messages. | string | ❌ | No | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Email, by default we would mark emails as unique but if organizations want, they can choose to update it to non unique. Can we put
Unique as true with **.
where ** is Unless organizations explicitly mark emails as non unique via preferences. Basically organizations can update the uniqueness check on email. So whatever message seems fine
Published docs preview URL: https://devrev-preview-e142812e-1b6b-4321-9c86-77fed3e83008.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-25968cde-d85e-4a5d-ba72-940fd59a59cb.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-51717e52-d810-495a-a058-83d3ee93a084.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-4c40b426-9f4f-45c5-b18f-592b0ebfc041.docs.buildwithfern.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Published docs preview URL: https://devrev-preview-82455c2a-25ea-4c4f-b14d-87e84b60bf4b.docs.buildwithfern.com |
Published docs preview URL: https://devrev-preview-ebb2a6aa-0f08-41ee-bcf1-c5f9befc5178.docs.buildwithfern.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestions are mostly superficial but please address them before merging.
- Populate user traits like email and display name to: | ||
- Make users identifiable | ||
- Prevent duplicate users across integrations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to have these inline.
- Populate user traits like email and display name to: | |
- Make users identifiable | |
- Prevent duplicate users across integrations | |
- Populate user traits like email and display name to make users identifiable and to prevent duplicate users across integrations. |
- Maintain consistent unique identifiers across your system | ||
- Follow the specified formats for phone numbers and domains | ||
- Keep your application access token secure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These items should end with a period.
- Maintain consistent unique identifiers across your system | |
- Follow the specified formats for phone numbers and domains | |
- Keep your application access token secure | |
- Maintain consistent unique identifiers across your system. | |
- Follow the specified formats for phone numbers and domains. | |
- Keep your application access token secure. |
- What to include: User, workspace and account information | ||
- Only use workspace information if your business model requires workspace organization | ||
|
||
In a DevOrg, unique identifiers are utilized to handle objects. If an object doesn't exist, it is created and then an attempt is made to link it. For example, here's how it operates: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a DevOrg, unique identifiers are utilized to handle objects. If an object doesn't exist, it is created and then an attempt is made to link it. For example, here's how it operates: | |
In a dev org, unique identifiers are utilized to handle objects. If an object doesn't exist, it is created and then an attempt is made to link it. For example, here's how it operates: |
|
||
DevRev offers three ways to structure your customer's data: | ||
1. **Single-level (Recommended for most B2C cases)** | ||
- User |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this means.
### How resolution works | ||
|
||
DevRev offers three ways to structure your customer's data: | ||
1. **Single-level (Recommended for most B2C cases)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list would probably be better as a table with columns number of levels, use case, user relationship, and required information.
If you prefer a two-level structure, where users are directly associated with an account instead of a workspace, you can provide the `user_ref` and details along with the `account_ref` and details. | ||
### API status codes and troubleshooting | ||
|
||
| Status code| Description & Troubleshooting | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to have troubleshooting at its own column.
| Status code| Description & Troubleshooting | | |
| Status code| Description | Troubleshooting | |
|-----------------|-------------------------------------------------------------------------------------------------------------------|--------|----------|--------| | ||
| `account_ref` | A unique reference for the account. | string | ❌ | ✅ | | ||
| `display_name` | The name of the account that's shown on the widget. | string | ❌ | ✅ | | ||
| `domains` | Use a unique format like 'devrev.ai'. Formats such as 'https://devrev.ai' or 'www.devrev.ai' are not valid. | array | ❌ | ✅ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what "unique" is supposed to mean.
| `domains` | Use a unique format like 'devrev.ai'. Formats such as 'https://devrev.ai' or 'www.devrev.ai' are not valid. | array | ❌ | ✅ | | |
| `domains` | Use a format like `devrev.ai`. Formats such as `https://devrev.ai` or `www.devrev.ai` are not valid. | array | ❌ | ✅ | |
| user_ref | A unique user reference that the DevRev app uses for identifying your users. This parameter is required. | string | ✅ | ✅ | | ||
| email | The email address of the customer. It's used for sending email notifications of any support messages. | string | ❌ | ✅** | | ||
| display_name | The name of the user that's shown on the widget. | string | ❌* | ❌ | | ||
| phone_numbers | The customer's mobile number, which must adhere to the E.164 format. | array | ❌ | ❌ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| user_ref | A unique user reference that the DevRev app uses for identifying your users. This parameter is required. | string | ✅ | ✅ | | |
| email | The email address of the customer. It's used for sending email notifications of any support messages. | string | ❌ | ✅** | | |
| display_name | The name of the user that's shown on the widget. | string | ❌* | ❌ | | |
| phone_numbers | The customer's mobile number, which must adhere to the E.164 format. | array | ❌ | ❌ | | |
| `user_ref` | A unique user reference that the DevRev app uses for identifying your users. This parameter is required. | string | ✅ | ✅ | | |
| `email` | The email address of the customer. It's used for sending email notifications of any support messages. | string | ❌ | ✅** | | |
| `display_name` | The name of the user that's shown on the widget. | string | ❌* | ❌ | | |
| `phone_numbers` | The customer's mobile number, which must adhere to the E.164 format. | array | ❌ | ❌ | |
@@ -18,7 +16,7 @@ Ensure you copy your access token, as you will not be able to view it again. | |||
## Generate a session token | |||
|
|||
<Callout intent="note"> | |||
For security reasons, this call should be made from the server side so that your AAT isn't exposed. | |||
For security reasons, this API call must be made from your server side to prevent exposing your Application Access Token (AAT). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For security reasons, this API call must be made from your server side to prevent exposing your Application Access Token (AAT). | |
For security reasons, this API call must be made from the server side to prevent exposing your application access token (AAT). |
no-work-item