Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update identify-web-user.mdx #188

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Update identify-web-user.mdx #188

wants to merge 14 commits into from

Conversation

Atul-Butola
Copy link
Contributor

no-work-item

@Atul-Butola Atul-Butola requested a review from a team as a code owner April 2, 2025 08:52
@Atul-Butola Atul-Butola marked this pull request as draft April 2, 2025 08:53
Copy link
Contributor

github-actions bot commented Apr 2, 2025

🌟 EkLine Reviewer

Hello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page.

For questions or feedback, please email [email protected].

Copy link
Contributor

github-actions bot commented Apr 2, 2025

@@ -102,7 +102,7 @@ If you prefer a two-level structure, where users are directly associated with an
|`account_ref` |A unique reference for the account. |string |
|`display_name` | The name of the account that's shown on the widget. |string |
|`domains` |The domain names of the accounts that the users belongs to. |array |
| `phone_numbers` |The phone number associated with the account. |array |
|`phone_numbers` |The phone number associated with the account must be in E.164 format. |array |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|`phone_numbers` |The phone number associated with the account must be in E.164 format. |array |
|`phone_numbers` |The phone number associated with the account in E.164 format. |array |

@Atul-Butola Atul-Butola marked this pull request as ready for review April 8, 2025 05:48
| Attributes | Description | Type | Required | Unique |
|---------------|-----------------------------------------------------------------------------|--------|----------|--------|
| user_ref | A unique user reference that the DevRev app uses for identifying your users. This parameter is required. | string | ✅ | Yes |
| email | The email address of the customer. It's used for sending email notifications of any support messages. | string | ❌ | No |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Email, by default we would mark emails as unique but if organizations want, they can choose to update it to non unique. Can we put
Unique as true with **.

where ** is Unless organizations explicitly mark emails as non unique via preferences. Basically organizations can update the uniqueness check on email. So whatever message seems fine

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Copy link
Contributor

github-actions bot commented Apr 8, 2025

@Atul-Butola Atul-Butola changed the title **WIP** Update identify-web-user.mdx Update identify-web-user.mdx Apr 8, 2025
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [EkLine] reported by reviewdog 🐶

Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

Ensure you copy your access token, as you will not be able to view it again.

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@bc-devrev bc-devrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestions are mostly superficial but please address them before merging.

Comment on lines +156 to +158
- Populate user traits like email and display name to:
- Make users identifiable
- Prevent duplicate users across integrations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to have these inline.

Suggested change
- Populate user traits like email and display name to:
- Make users identifiable
- Prevent duplicate users across integrations
- Populate user traits like email and display name to make users identifiable and to prevent duplicate users across integrations.

Comment on lines +159 to +161
- Maintain consistent unique identifiers across your system
- Follow the specified formats for phone numbers and domains
- Keep your application access token secure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These items should end with a period.

Suggested change
- Maintain consistent unique identifiers across your system
- Follow the specified formats for phone numbers and domains
- Keep your application access token secure
- Maintain consistent unique identifiers across your system.
- Follow the specified formats for phone numbers and domains.
- Keep your application access token secure.

- What to include: User, workspace and account information
- Only use workspace information if your business model requires workspace organization

In a DevOrg, unique identifiers are utilized to handle objects. If an object doesn't exist, it is created and then an attempt is made to link it. For example, here's how it operates:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In a DevOrg, unique identifiers are utilized to handle objects. If an object doesn't exist, it is created and then an attempt is made to link it. For example, here's how it operates:
In a dev org, unique identifiers are utilized to handle objects. If an object doesn't exist, it is created and then an attempt is made to link it. For example, here's how it operates:


DevRev offers three ways to structure your customer's data:
1. **Single-level (Recommended for most B2C cases)**
- User
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this means.

### How resolution works

DevRev offers three ways to structure your customer's data:
1. **Single-level (Recommended for most B2C cases)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list would probably be better as a table with columns number of levels, use case, user relationship, and required information.

If you prefer a two-level structure, where users are directly associated with an account instead of a workspace, you can provide the `user_ref` and details along with the `account_ref` and details.
### API status codes and troubleshooting

| Status code| Description & Troubleshooting |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to have troubleshooting at its own column.

Suggested change
| Status code| Description & Troubleshooting |
| Status code| Description | Troubleshooting |

|-----------------|-------------------------------------------------------------------------------------------------------------------|--------|----------|--------|
| `account_ref` | A unique reference for the account. | string | ❌ | ✅ |
| `display_name` | The name of the account that's shown on the widget. | string | ❌ | ✅ |
| `domains` | Use a unique format like 'devrev.ai'. Formats such as 'https://devrev.ai' or 'www.devrev.ai' are not valid. | array | ❌ | ✅ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what "unique" is supposed to mean.

Suggested change
| `domains` | Use a unique format like 'devrev.ai'. Formats such as 'https://devrev.ai' or 'www.devrev.ai' are not valid. | array |||
| `domains` | Use a format like `devrev.ai`. Formats such as `https://devrev.ai` or `www.devrev.ai` are not valid. | array |||

Comment on lines +63 to +66
| user_ref | A unique user reference that the DevRev app uses for identifying your users. This parameter is required. | string | ✅ | ✅ |
| email | The email address of the customer. It's used for sending email notifications of any support messages. | string | ❌ | ✅** |
| display_name | The name of the user that's shown on the widget. | string | ❌* | ❌ |
| phone_numbers | The customer's mobile number, which must adhere to the E.164 format. | array | ❌ | ❌ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| user_ref | A unique user reference that the DevRev app uses for identifying your users. This parameter is required. | string |||
| email | The email address of the customer. It's used for sending email notifications of any support messages. | string ||** |
| display_name | The name of the user that's shown on the widget. | string |* ||
| phone_numbers | The customer's mobile number, which must adhere to the E.164 format. | array |||
| `user_ref` | A unique user reference that the DevRev app uses for identifying your users. This parameter is required. | string |||
| `email` | The email address of the customer. It's used for sending email notifications of any support messages. | string ||** |
| `display_name` | The name of the user that's shown on the widget. | string |* ||
| `phone_numbers` | The customer's mobile number, which must adhere to the E.164 format. | array |||

@@ -18,7 +16,7 @@ Ensure you copy your access token, as you will not be able to view it again.
## Generate a session token

<Callout intent="note">
For security reasons, this call should be made from the server side so that your AAT isn't exposed.
For security reasons, this API call must be made from your server side to prevent exposing your Application Access Token (AAT).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For security reasons, this API call must be made from your server side to prevent exposing your Application Access Token (AAT).
For security reasons, this API call must be made from the server side to prevent exposing your application access token (AAT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants