Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Start Checklist #662

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Expose Start Checklist #662

merged 7 commits into from
Dec 18, 2023

Conversation

Jose10go
Copy link
Contributor

@Jose10go Jose10go commented Dec 18, 2023

This PR exposes the IntercomAPI startChecklist method so it can be used by the clients of the useIntercom hook.

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 37de962

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-use-intercom Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Jose10go Jose10go mentioned this pull request Dec 18, 2023
@Jose10go
Copy link
Contributor Author

Jose10go commented Dec 18, 2023

@devrnt Let me know if I am missing anything

Copy link
Owner

@devrnt devrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks! Looks good, just a few small remarks. Also please add a changeset: run the changeset script and follow the prompt (consider this a minor change)

packages/react-use-intercom/src/types.ts Show resolved Hide resolved
packages/react-use-intercom/src/types.ts Show resolved Hide resolved
devrnt

This comment was marked as duplicate.

devrnt

This comment was marked as duplicate.

@devrnt
Copy link
Owner

devrnt commented Dec 18, 2023

Closes #661

@Jose10go Jose10go requested a review from devrnt December 18, 2023 15:43
@devrnt devrnt merged commit efbf3ae into devrnt:main Dec 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants