Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose showTicket and showConversation #671

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

bananazigzags
Copy link
Contributor

@bananazigzags bananazigzags commented Apr 15, 2024

Exposes showTicket and showConversation methods in useIntercom hook

Closes #670

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 55e4ddf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-use-intercom Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devrnt
Copy link
Owner

devrnt commented Apr 15, 2024

This is awesome big thanks!

Copy link
Owner

@devrnt devrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the linter

@bananazigzags
Copy link
Contributor Author

Please run the linter

For some reason, your lint:fix script didn't work for me. Tried passing --fix to "lint". Hope it worked fine

@devrnt devrnt self-requested a review April 16, 2024 06:04
@bananazigzags
Copy link
Contributor Author

Hi, do you have any pointers on how to fix the pipeline? I see a comment about one of the failing tests so it seems to be a recurring problem. No idea though why the other ones are failing.

@devrnt
Copy link
Owner

devrnt commented Apr 16, 2024

No idea to be honest, I'll have to look into it

@devrnt
Copy link
Owner

devrnt commented Apr 16, 2024

Should be resolved, sync with upstream please

@devrnt devrnt merged commit a11c11f into devrnt:main Apr 16, 2024
5 checks passed
@devrnt
Copy link
Owner

devrnt commented Apr 16, 2024

5.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose showTicket and showConversation methods
2 participants