docs: correct the Kover coverage floor claims from 80% to the real numbers - #139
Merged
Conversation
…r-module numbers
The CI comment and README both claimed a flat 80% line-coverage floor, but
kover { reports { verify } } in each module's build.gradle.kts sets different,
higher floors: kuri and kuri-bind require 99% line coverage (85% and 88%
branch respectively), and kuri-serde-kotlinx requires 90% line / 80% branch.
80% never appears in any module's Kover config, so the documented number was
simply wrong and could mislead a contributor into expecting a build to pass
well below what koverVerify actually enforces.
Closes #91
… comment
The coverage-floor comment rewrite accidentally deleted the clause explaining
why the gradlew invocation is piped through tee/grep, leaving a broken fragment
("Piped through fails the step)") with a dangling parenthesis. Restore the
"tee/grep (pipefail is on by default ..." line so the comment reads coherently
again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kuriandkuri-bindboth require 99% line coverage (85% and 88% branch respectively), andkuri-serde-kotlinxrequires 90% line / 80% branch, per each module'skover { reports { verify } }block.>=80%to>=90%(the true floor across all three modules, since it can only show one number).site/src/content/docs/guides/building-from-source.mdxrepeats the same wrong figure, but that file only exists on the still-unmergeddocs/astro-sitebranch (PR feat: add a documentation site (Astro + Starlight) #81), not onmain, so it isn't part of this diff — I pushed the equivalent fix directly onto that branch so the correct numbers land whenever feat: add a documentation site (Astro + Starlight) #81 merges.Test plan
build.gradle.ktskoverblock (kuri/build.gradle.kts:226-227,kuri-bind/build.gradle.kts:94-95,kuri-serde-kotlinx/build.gradle.kts:86-87).Closes #91