Make build plugin communicate files via a file list rather than space-separated CLI arguments #10
Conversation
…-separated CLI arguments
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 97.66% 97.63% -0.03%
==========================================
Files 37 37
Lines 7322 7324 +2
==========================================
Hits 7151 7151
- Misses 171 173 +2
|
| ) | ||
| .write(toPath: inputSwiftFilesFilePath) | ||
| let arguments = [ | ||
| "--swift-file-paths-file-path", |
There was a problem hiding this comment.
I don't love this argument name. If you've got better ideas, I am all ears.
There was a problem hiding this comment.
--swift-sources-file-path--swift-source-files-file-path--swift-source-list-file-path
Best I got
| @@ -112,3 +133,17 @@ extension SafeDIGenerateDependencyTree: XcodeBuildToolPlugin { | |||
| } | |||
| } | |||
| #endif | |||
|
|
|||
| extension Data { | |||
| fileprivate func write(toPath filePath: String) throws { | |||
There was a problem hiding this comment.
This extension also exists in another module, but this plug in module cannot depend on any other library we have in this package
| #if os(Linux) | ||
| try write(to: URL(fileURLWithPath: filePath)) | ||
| #else | ||
| if #available(macOS 13.0, iOS 16.0, tvOS 16.0, watchOS 9.0, *) { | ||
| try write(to: URL(filePath: filePath)) | ||
| } else { | ||
| try write(to: URL(fileURLWithPath: filePath)) | ||
| } | ||
| #endif | ||
| } |
There was a problem hiding this comment.
This can't be simplified?
if #available(macOS 13.0, iOS 16.0, tvOS 16.0, watchOS 9.0, *) {
try write(to: URL(filePath: filePath))
} else {
try write(to: URL(fileURLWithPath: filePath))
}
There was a problem hiding this comment.
Ah nvm, it's #if something not if #something
There was a problem hiding this comment.
yup. tried that 🙂. Took me awhile to get this right. Linux availability support is... bad (read: nonexistent).
|
I'll merge this at the same time as #8 so we can roll a single breaking change. |
|
Merging this, but @MrAdamBoyd if you have more feedback on what I pushed after you reviewed let me know – happy to address post-merge. I won't be releasing for a few days so we have time. |
This PR speeds up the SafeDI plugin by using a
.csvfile to transfer the file list to the plugin rather than sending the file list over as a very long CLI argument.This code is tested via the
Build Project Integration on Xcode 15job.I removed the option to pass in an array of swift file paths to the SafeDITool, which makes this change a breaking one.