Skip to content

Refactor property validation and simplify generation #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 19, 2024
Merged

Refactor property validation and simplify generation #26

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
197f950
Use 'container: swift:5.9' instead of 'swift-actions/setup-swift@v1'
dfed Jan 19, 2024
6c341c5
Add tests that fail to pass or crash
dfed Jan 19, 2024
450833b
Add associated values to Dependency.Source to uniformly capture the d…
dfed Jan 19, 2024
4839eeb
Property detect created properties on a scope that are fulfillable
dfed Jan 19, 2024
c85d4e6
Ensure that we can not fulfill a received property with ourself
dfed Jan 19, 2024
41f8875
Remove potential for assertion - sort dependencies and generate rathe…
dfed Jan 19, 2024
a88955b
Merge branch 'main' into dfed--refactor-property-resolution
dfed Jan 19, 2024
346e1da
Rename propertiesToInstantiate -> propertiesToGenerate
dfed Jan 19, 2024
4e8dd1a
Add another test
dfed Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,10 @@ jobs:
linux:
name: Build and Test on Linux
runs-on: ubuntu-latest
container: swift:5.9
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following the advice here to avoid this kind of CI failure

steps:
- name: Checkout Repo
uses: actions/checkout@v4
- name: Setup Swift Environment
uses: swift-actions/setup-swift@v1
with:
swift-version: 5.9
- name: Build and Test Framework
run: swift test -c release --enable-code-coverage -Xswiftc -enable-testing
- name: Prepare Coverage Reports
Expand Down
Loading