This repository was archived by the owner on Nov 19, 2024. It is now read-only.
[FINAL] feat: [EXC-1676] add allowed viewers variant to canister's log visibility #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymar
commented
Jul 27, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
maksymar
changed the title
maksymar
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
mraszyk
reviewed
Aug 11, 2024
Co-authored-by: mraszyk <[email protected]>
Dfinity-Bjoern
changed the title
ghost
requested a review
from
This comment was marked as resolved.
This comment was marked as resolved.
Dfinity-Bjoern
approved these changes
Nov 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
allowed_viewersvariant to canister'slog_visibilitywhich allows to fetch logs by specified number of principals.