Skip to content

Fix memory leaks in List.addRepeat, List.removeLast. #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
+3 −2
Closed

Fix memory leaks in List.addRepeat, List.removeLast. #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb78bbe
Fix memory leaks in addRepeat, removeLast.
AStepanov25 Jul 9, 2025
6bf378b
Fix.
AStepanov25 Jul 9, 2025
f10c971
Merge branch 'main' into fix-memory-leaks
AStepanov25 Jul 9, 2025
5fdf08b
Simplify.
AStepanov25 Jul 9, 2025
c867ed6
Merge branch 'main' into fix-memory-leaks
AStepanov25 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* Add `PriorityQueue` (#392).
* Add support for Weak references (#388).
* Clarify difference between `List` and `pure/List` in doc comments (#386).
* Fix memory leak bugs in `List.addRepeat<T>` and `List.removeLast<T>` (#343).

## 1.0.0

Expand Down
4 changes: 2 additions & 2 deletions src/List.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ module {
var cnt = count;
while (cnt > 0) {
let db_size = data_block_size(list.blockIndex);
if (list.elementIndex == 0 and db_size <= cnt) {
if (list.elementIndex == 0 and db_size <= cnt and list.blocks[list.blockIndex].size() == 0) {
list.blocks[list.blockIndex] := VarArray.repeat<?T>(?initValue, db_size);
cnt -= db_size;
list.blockIndex += 1
Expand Down Expand Up @@ -470,7 +470,7 @@ module {

// Keep one totally empty block when removing
if (blockIndex + 2 < list.blocks.size()) {
if (list.blocks[blockIndex + 2].size() == 0) {
if (list.blocks[blockIndex + 2].size() > 0) {
list.blocks[blockIndex + 2] := [var]
}
};
Expand Down