refactors to self parameter #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

christoph-dfinity wants to merge 29 commits into claudio/implicits from christoph/selfless-dot

Contributor

christoph-dfinity commented Oct 22, 2025 •

edited

Loading

I'd recommend starting by looking at validation/api/api.lock.json


          refactors to self parameter

632a5a2

github-actions bot commented Oct 22, 2025 •

edited

Loading

✨ Documentation preview for 1903517:

https://dfinity.github.io/motoko-core/pull/412 (source code)


          updates api lock

645b27f

crusso reviewed

View reviewed changes

validation/api/api.lock.json Outdated Show resolved Hide resolved

crusso reviewed

View reviewed changes

validation/api/api.lock.json Outdated Show resolved Hide resolved

crusso reviewed

View reviewed changes

validation/api/api.lock.json Outdated Show resolved Hide resolved

crusso reviewed

View reviewed changes

validation/api/api.lock.json Outdated Show resolved Hide resolved

crusso reviewed

View reviewed changes

validation/api/api.lock.json Show resolved Hide resolved

christoph-dfinity added 6 commits

October 23, 2025 07:39


          missed a few

5d16fbf


          un-self overlapping functions between pure/List and Option

a55d261


          disable dot-notation for

1d18f65


          formatting

0cc85c4


          revert: re-self functions in pure/List

455fa03


          update api.lock

ee9dc11

crusso reviewed

View reviewed changes

src/Text.mo Outdated Show resolved Hide resolved

crusso reviewed

View reviewed changes

validation/api/api.lock.json Show resolved Hide resolved

crusso added 2 commits

October 27, 2025 17:56


          fix regression in Text.mo

dbc3dba


          swap Float.format args

crusso mentioned this pull request

chore: fixes to christoph/selfless-dot #416

Merged

crusso added 8 commits

October 27, 2025 18:26


          fix bug in List.mo


          identify failing RealTimeQueue test

e265b77


          fix List (again)

ae011d3


          RealTimeQueue ok after all (affected by List?)


          prettier

09f61fb


          adjust Nat.toText for self

23bbe2f


          fix relational on Char

7c38d3a


          tweak Nat.toText def

17b0d83

crusso mentioned this pull request

Carlo/implicits additions #415

Closed

Contributor

crusso commented Oct 27, 2025

Maybe we should adapt some of the changes from #415

Contributor

crusso commented Oct 27, 2025 •

edited

Loading

Text.join fails in motoko-training https://github.com/dfinity/motoko-training/pull/1618 (no longer a method in current, self-less form). I guess we should flip the arguments as per the TODO.

christoph-dfinity and others added 8 commits

October 28, 2025 09:48


          remove TODO

fa0ad40


          updates pure/Set to self parameters

afc53db


          add more conversion functions

598042c


          adds Nat.toFloat

9821fe7


          swap Text.join args, adding self


          add canonical converstion from iterators to collections

4a4e2f3


          Principal, Set.toSet and List.equal/compare fixes

68b810f


          re-selfify abs

f66ba8e

crusso mentioned this pull request

experiment: make numeric operations selfless, apart from conversions #419

Merged

crusso added 3 commits

November 3, 2025 13:30


          experiment: make numeric operations selfless, apart from conversions (#…

3bc490a

…419)

* make numeric operations selfless, apart from conversions

* Int64 too

* x -> from(Inclusive)

* allow f.isNaN and f.isNegative

* validate api


          merge with parent, selfify new ops

b56da3b


          renamings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet