Added deduplicate. #425
Open
Added deduplicate. #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timohanke
reviewed
Nov 19, 2025
| case _ return | ||
| }; | ||
|
|
||
| list.blockIndex := 1; |
Contributor
There was a problem hiding this comment.
Can we also set this to 2 and then skip the first addUnsafe two lines below?
Just asking to understand. Code might be more readable as it is now.
Btw, I recommend making a code comment where the function addUnsafe is defined and explain the function. It's a private function as doesn't have a comment right now.
Contributor
Author
There was a problem hiding this comment.
Yes, we can set to 2. Code is indeed more readable as it is now.
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.