Skip to content

update: New & Old base library doc generation #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 24, 2025
Merged

update: New & Old base library doc generation #5003

merged 21 commits into from
Jun 24, 2025

Conversation

@jessiemongeon1
Copy link
Contributor

@jessiemongeon1 jessiemongeon1 commented Apr 3, 2025 •
edited by crusso
Loading

  • adapt nix and build scripts to pull in and generate both base and code docs
  • adapt make preview to show both base and code docs
  • add generated core docs, update base docs
  • add --package option to mo-doc to prefix module documentation with package name (to distinguish base from core)

@jessiemongeon1 jessiemongeon1 changed the title update: Base library doc generation update: New & Old base library doc generation Apr 3, 2025
@jessiemongeon1 jessiemongeon1 marked this pull request as ready for review June 11, 2025 18:10
@jessiemongeon1 jessiemongeon1 requested a review from a team as a code owner June 11, 2025 18:10
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025 •
edited
Loading

Comparing from aea7f5c to 33eb079:
The produced WebAssembly code seems to be completely unchanged.

rvanasa
rvanasa reviewed Jun 12, 2025
View reviewed changes
jessiemongeon1 and others added 2 commits June 18, 2025 10:17
crusso
crusso reviewed Jun 18, 2025
View reviewed changes
crusso
crusso reviewed Jun 18, 2025
View reviewed changes
@crusso crusso requested a review from christoph-dfinity June 19, 2025 15:49
@rvanasa rvanasa mentioned this pull request Jun 23, 2025
Merged
christoph-dfinity
christoph-dfinity approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@christoph-dfinity christoph-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessiemongeon1 jessiemongeon1 added the automerge-squash When ready, merge (using squash) label Jun 24, 2025
@mergify mergify bot merged commit acf71f3 into master Jun 24, 2025
36 of 42 checks passed
@mergify mergify bot deleted the update-base-doc-generation branch June 24, 2025 14:30
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crusso crusso crusso left review comments

@rvanasa rvanasa rvanasa left review comments

@christoph-dfinity christoph-dfinity christoph-dfinity approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jessiemongeon1 @crusso @rvanasa @christoph-dfinity