test: adds playwright tests for dfx new project frontends
#4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
approved these changes
Jan 17, 2025
raymondk
reviewed
Jan 17, 2025
| @@ -381,7 +381,7 @@ Module hash 15da2adc4426b8037c9e716b81cb6a8cf1a835ac37589be2cef8cb3f4a04adaa | |||
|
|
|||
| `dfx deploy --mode` now takes the same possible values as `dfx canister install --mode`: "install", "reinstall", "upgrade" and "auto". | |||
|
|
|||
| In "auto" mode, the upgrade options are hints which only take effects when the actual install mode is "upgrade". | |||
| In "auto" mode, the upgrade options are hints which only take effects when the actual install mode is "upgrade". | |||
There was a problem hiding this comment.
Small typo? "Only take effect"
There was a problem hiding this comment.
Oh, that typo was already in there - my auto formatter just removed the space when I updated the file
I did - this was the easiest way to represent each frontend as a separate test suite so it will be easier to identify if and when one of them fails. I am in favor of avoiding duplication as a principle, but here it's easier to just work with the tool than fight it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends playwright coverage to the remaining frontend projects
Fixes SDK-1931
How Has This Been Tested?
It's all tests!
Checklist: