Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes unnecessary tsc step in sveltekit build script #4070

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: removes unnecessary tsc step in sveltekit build script #4070

merged 1 commit into from
Jan 21, 2025

Conversation

krpeacock
Copy link
Contributor

Description

We were encountering build failures on the sveltekit starter, and this will both improve the build process and and unblock CI

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock force-pushed the kaia/sveltekit-breaking branch from 7613c91 to 7da69f1 Compare January 21, 2025 17:35
@krpeacock krpeacock marked this pull request as ready for review January 21, 2025 17:35
@krpeacock krpeacock requested a review from a team as a code owner January 21, 2025 17:35
@krpeacock
Copy link
Contributor Author

I think the current error may be flakiness?

@krpeacock krpeacock merged commit 47f6b43 into master Jan 21, 2025
296 checks passed
@krpeacock krpeacock deleted the kaia/sveltekit-breaking branch January 21, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krpeacock @ericswanson-dfinity