Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add return types to doc blocks #45

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

madflow
Copy link
Contributor

@madflow madflow commented Oct 25, 2022

  1x: Method "ArrayAccess::offsetExists()" might add "bool" as a native return type declaration in the future. Do the same in implementation "Dflydev\DotAccessData\Data" now to avoid errors or add an explicit @return annotation to suppress this message.

  1x: Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Dflydev\DotAccessData\Data" now to avoid errors or add an explicit @return annotation to suppress this message.


  1x: Method "ArrayAccess::offsetSet()" might add "void" as a native return type declaration in the future. Do the same in implementation "Dflydev\DotAccessData\Data" now to avoid errors or add an explicit @return annotation to suppress this message.


  1x: Method "ArrayAccess::offsetUnset()" might add "void" as a native return type declaration in the future. Do the same in implementation "Dflydev\DotAccessData\Data" now to avoid errors or add an explicit @return annotation to suppress this message.

See #44

Copy link
Contributor

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be safe to release as a patch or minor release.

@simensen
Copy link
Member

@colinodell I believe I just gave you maintainer privs on this repository. Let me know if you'd like to do this release yourself or if you'd like me to.

@colinodell
Copy link
Contributor

colinodell commented Oct 27, 2022

Thanks @simensen! I'll get this merged and released shortly :)

@colinodell colinodell force-pushed the fix/return-types-to-doc-blocks branch from e14b82c to 7a04329 Compare October 27, 2022 11:40
@colinodell colinodell merged commit 72540c9 into dflydev:main Oct 27, 2022
@madflow madflow deleted the fix/return-types-to-doc-blocks branch October 27, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants