-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow psr/http-message ^2 #60
Conversation
Also allow expected composer plugins and set minimum php version to keep lockfile compatible with lowest supported version . Adds parameter and return type hints to all test stubs for psr/http-message v2 compatibility. Some tests will fail due to incompatible signatures when deps are at lowest.
- Install correct PHPUnit requirement on newer PHP versions
9f65983
to
17f6738
Compare
- Install correct PHPUnit requirement on newer PHP versions - Only upload coverage when the repository matches `dflydev/dflydev-fig-cookies`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eager to get this change also. You'd want to check that both versions are being installed, although since the changes in v2 are isolated to getBody
and getContents
, this library shouldn't be affected.
@simensen - Hate to be a nag, but is there any chance you could take a look at this one? |
Also allow expected composer plugins and set minimum php version to keep lockfile compatible with lowest supported version of PHP.
Adds parameter and return type hints to all test stubs for psr/http-message v2 compatibility. Some tests will fail due to incompatible signatures when deps are at lowest - hopefully this is acceptable for test code considering tests don't appear to run with
--prefer-lowest
Also adds 8.1 and 8.2 to the matrix