Ignores faad2 "bitstream value not allowed by specification" errors. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors resulted in "invalid file format" errors on otherwise good files. The faad2 decoder simply skips over these packets and moves on, and it's unrelated to any of the functionality of aacgain.
|
Do you have one of these files that you could send me? If you want to do it OOB my email is in the commit logs. I wonder if bumping to the latest faad helps? It's probably worth doing anyway, even if it doesn't fix this issue. |
|
I just sent you an email with some test files. |
|
@carter-thaxton does this have to do with AAC streams that have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors resulted in "invalid file format" errors on otherwise good files.
The faad2 decoder simply skips over these packets and moves on, and it's unrelated to any of the functionality of aacgain.