add exponential retry if TxnConflictException occures #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaji-kharse
force-pushed
the
shiva/retry
branch
2 times, most recently
from
b7bc6bf
to
750d7be
Compare
rarvikar
reviewed
Jul 24, 2024
| if (code.equals(Status.Code.ABORTED) | ||
| || code.equals(Status.Code.FAILED_PRECONDITION)) { | ||
| throw new CompletionException(new TxnConflictException(desc)); | ||
| return executeWithExponentialBackoff( |
There was a problem hiding this comment.
We should provide the user the option to retry the transaction rather than forcing one. In some use-cases like BnF, it may not be desirable to retry all transactions that failed due to a conflict.
shivaji-kharse
force-pushed
the
shiva/retry
branch
from
d41490d
to
7585011
Compare
|
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.