Add support for Battery Video Doorbell Pro #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the device type for the battery version of the Video Doorbell Pro
|
There is also a cocoa_doorbell_v2, I do not own this device - I think this is a Battery Doorbell Plus |
dgreif
approved these changes
Jan 12, 2025
dgreif
pushed a commit
that referenced
this pull request
Jan 12, 2025
* Add support for Battery Video Doorbell Pro Adds the device type for the battery version of the Video Doorbell Pro * Add support for Battery Doorbell Plus
dgreif
pushed a commit
that referenced
this pull request
Jan 12, 2025
* Add support for Battery Video Doorbell Pro Adds the device type for the battery version of the Video Doorbell Pro * Add support for Battery Doorbell Plus
dgreif
pushed a commit
that referenced
this pull request
Jan 12, 2025
* Add support for Battery Video Doorbell Pro Adds the device type for the battery version of the Video Doorbell Pro * Add support for Battery Doorbell Plus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently purchased the Pro version of the Battery Video Doorbell - I am trying to get the actual device model to show up on the addons I use, Scrypted, Home Assistant (etc.) it makes the device look better rather it saying unknown model in Homekit 😋
I presume just the v3 visual identifier needs to be added in the types - functionality is working 👍🏻