Skip to content

Fix zombie Chrome processes by calling wait() after kill #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
T3-WT wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix zombie Chrome processes by calling wait() after kill #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions backend/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,15 @@ async def cleanup_chrome_by_pid(chrome_process, user_data_dir="/tmp", time_at_st
proc.kill() # SIGKILL immediately - no waiting
except (psutil.NoSuchProcess, psutil.AccessDenied):
pass
# Reap the main chrome process to prevent zombies
try:
loop = asyncio.get_event_loop()
await asyncio.wait_for(
loop.run_in_executor(None, chrome_process.wait),
timeout=5.0
)
except (asyncio.TimeoutError, Exception) as e:
logger.warning(f"WebSocket ID: {websocket.id} - Error reaping Chrome process: {str(e)}")

logger.debug(f"WebSocket ID: {websocket.id} - Chrome PID {chrome_process.pid} cleanup signaled")
except (psutil.NoSuchProcess, psutil.AccessDenied, OSError):
Expand Down